21 Oct
2014
21 Oct
'14
8:50 a.m.
I *believe* that there is a bug in Zelig's scoping. This exists on the cran
version (from where it bit me) but also in the development version.
Interactively, the Zelig demo works fine:
Note that assigning cars to x and then passing x as the argument to data is
needed to demonstrate the bug. The problem comes when we wrap this code
within a function.
It is the Error above that is the problem. (Strangely, the code still seems
to work in the development version after issuing that Error message. In the
CRAN version, it does not.)
Note that you need to keep your workplace clean to see this clearly. See
the rm(list = ls()) above. If you don't issue this command (after doing the
interactive code), you don't get any error:
> rm(list = ls())
No Error because Zelig finds x in the global environment. Of course, it
should be using the local x.
My colleague thinks that, in the CRAN version, this snippet of code is
wrong:
divided.data <- eval(call("multi.dataset", substitute(data)))
But I am not enough of an R guru to determine the cause of the bug.
Thanks,
Dave Kane
packageVersion("Zelig")
[1]
"5.0.2"
data(cars)
x <- cars
zelig(dist ~ speed, data = x, model = "ls")
How to cite this model in
Zelig:
Kosuke Imai, Gary King, and Olivia Lau. 2007.
...
rm(list = ls())
test_function <- function(){data(cars); x <- cars; zelig(dist ~ speed,
data =
x, model = "ls")}
test_function()
Error in callSuper(formula =
formula, data = data, ..., weights = NULL, :
object 'x' not found
How to cite this model in Zelig:
Kosuke Imai, Gary King, and Olivia Lau. 2007.
...
data(cars)
x <- cars
zelig(dist ~ speed, data = x, model = "ls")
How to cite this model in
Zelig:
Kosuke Imai, Gary King, and Olivia Lau. 2007.
...
test_function <- function(){data(cars); x <-
cars; zelig(dist ~ speed,
data = x, model = "ls")}
test_function()
How to cite this model in
Zelig:
Kosuke Imai, Gary King, and Olivia Lau. 2007.
...
29 Oct
29 Oct
11:25 a.m.
Hi David:
More on Zelig 4 scoping rules can be found here:
https://lists.gking.harvard.edu/pipermail/zelig/2013-May/001190.html.
In Zelig 5, the error was coming from a flag not set to silent in
“wrappers.R” and was not affecting further code execution. So
mf <- try(eval(mf, environment()))
is now
mf <- try(eval(mf, environment()), silent = TRUE)
Running your example, we get:
rm(list = ls())
test_function <- function() {
data(cars)
x <- cars
zelig(dist ~ speed, data = x, model = "ls", cite = FALSE)}
test_function()
## Model:
## $by
## [1] 1
##
##
## Call:
## stats::lm(formula = formula, data = .)
##
## Coefficients:
## (Intercept) speed
## -17.579 3.932
##
## Next step: Use 'setx' method
(https://github.com/IQSS/Zelig/issues/49)
Best regards,
Christine
On Tue, Oct 21, 2014 at 8:50 AM, David Kane <dave.kane(a)gmail.com> wrote:
I *believe* that there is a bug in Zelig's
scoping. This exists on the
cran version (from where it bit me) but also in the development version.
Interactively, the Zelig demo works fine:
Note that assigning cars to x and then passing x as the argument to data
is needed to demonstrate the bug. The problem comes when we wrap this code
within a function.
It is the Error above that is the problem. (Strangely, the code still
seems to work in the development version after issuing that Error message.
In the CRAN version, it does not.)
Note that you need to keep your workplace clean to see this clearly. See
the rm(list = ls()) above. If you don't issue this command (after doing the
interactive code), you don't get any error:
> rm(list = ls())
No Error because Zelig finds x in the global environment. Of course, it
should be using the local x.
My colleague thinks that, in the CRAN version, this snippet of code is
wrong:
divided.data <- eval(call("multi.dataset", substitute(data)))
But I am not enough of an R guru to determine the cause of the bug.
Thanks,
Dave Kane
-
--
Zelig Mailing List, served by HUIT
Send messages: zelig(a)lists.gking.harvard.edu
[un]subscribe Options:
http://lists.gking.harvard.edu/mailman/listinfo/zelig
Zelig program information: http://gking.harvard.edu/zelig/
Zelig mailing list
Zelig(a)lists.gking.harvard.edu
To unsubscribe from this list or get other information:
https://lists.gking.harvard.edu/mailman/listinfo/zelig
packageVersion("Zelig")
[1]
"5.0.2"
data(cars)
x <- cars
zelig(dist ~ speed, data = x, model = "ls")
How to cite this model in
Zelig:
Kosuke Imai, Gary King, and Olivia Lau. 2007.
...
rm(list = ls())
test_function <- function(){data(cars); x <- cars; zelig(dist ~ speed,
data
= x, model = "ls")}
test_function()
Error in callSuper(formula
= formula, data = data, ..., weights = NULL, :
object 'x' not found
How to cite this model in Zelig:
Kosuke Imai, Gary King, and Olivia Lau. 2007.
...
data(cars)
x <- cars
zelig(dist ~ speed, data = x, model = "ls")
How to cite this model in
Zelig:
Kosuke Imai, Gary King, and Olivia Lau. 2007.
...
test_function <- function(){data(cars); x
<- cars; zelig(dist ~ speed,
data = x, model = "ls")}
test_function()
How to cite this model in
Zelig:
Kosuke Imai, Gary King, and Olivia Lau. 2007.
...
4 Nov
4 Nov
7:54 a.m.
Thanks for the reply. Could you clarify the resolution? That is, was this a
bug? Has it been fixed? Do I need to edit my personal copy of wrappers.R or
should I re-download Zelig?
Thanks,
Dave
On Wed, Oct 29, 2014 at 11:25 AM, Christine Choirat <cchoirat(a)gmail.com>
wrote:
Hi David:
More on Zelig 4 scoping rules can be found here:
https://lists.gking.harvard.edu/pipermail/zelig/2013-May/001190.html.
In Zelig 5, the error was coming from a flag not set to silent in
“wrappers.R” and was not affecting further code execution. So
mf <- try(eval(mf, environment()))
is now
mf <- try(eval(mf, environment()), silent = TRUE)
Running your example, we get:
rm(list = ls())
test_function <- function() {
data(cars)
x <- cars
zelig(dist ~ speed, data = x, model = "ls", cite = FALSE)}
test_function()
## Model:
## $by
## [1] 1
##
##
## Call:
## stats::lm(formula = formula, data = .)
##
## Coefficients:
## (Intercept) speed
## -17.579 3.932
##
## Next step: Use 'setx' method
(https://github.com/IQSS/Zelig/issues/49)
Best regards,
Christine
On Tue, Oct 21, 2014 at 8:50 AM, David Kane <dave.kane(a)gmail.com> wrote:
I *believe* that there is a bug in Zelig's
scoping. This exists on the
cran version (from where it bit me) but also in the development version.
Interactively, the Zelig demo works fine:
Note that assigning cars to x and then passing x as the argument to data
is needed to demonstrate the bug. The problem comes when we wrap this code
within a function.
It is the Error above that is the problem. (Strangely, the code still
seems to work in the development version after issuing that Error message.
In the CRAN version, it does not.)
Note that you need to keep your workplace clean to see this clearly. See
the rm(list = ls()) above. If you don't issue this command (after doing the
interactive code), you don't get any error:
> rm(list = ls())
No Error because Zelig finds x in the global environment. Of course, it
should be using the local x.
My colleague thinks that, in the CRAN version, this snippet of code is
wrong:
divided.data <- eval(call("multi.dataset", substitute(data)))
But I am not enough of an R guru to determine the cause of the bug.
Thanks,
Dave Kane
-
--
Zelig Mailing List, served by HUIT
Send messages: zelig(a)lists.gking.harvard.edu
[un]subscribe Options:
http://lists.gking.harvard.edu/mailman/listinfo/zelig
Zelig program information: http://gking.harvard.edu/zelig/
Zelig mailing list
Zelig(a)lists.gking.harvard.edu
To unsubscribe from this list or get other information:
https://lists.gking.harvard.edu/mailman/listinfo/zelig
packageVersion("Zelig")
[1]
"5.0.2"
data(cars)
x <- cars
zelig(dist ~ speed, data = x, model = "ls")
How to cite this model in
Zelig:
Kosuke Imai, Gary King, and Olivia Lau. 2007.
...
rm(list = ls())
test_function <- function(){data(cars); x <- cars; zelig(dist ~ speed,
data
= x, model = "ls")}
test_function()
Error in callSuper(formula
= formula, data = data, ..., weights = NULL,
:
object 'x' not found
How to cite this model in Zelig:
Kosuke Imai, Gary King, and Olivia Lau. 2007.
...
data(cars)
x <- cars
zelig(dist ~ speed, data = x, model = "ls")
How to cite this model in
Zelig:
Kosuke Imai, Gary King, and Olivia Lau. 2007.
...
test_function <- function(){data(cars); x
<- cars; zelig(dist ~ speed,
data = x, model = "ls")}
test_function()
How to cite this model in
Zelig:
Kosuke Imai, Gary King, and Olivia Lau. 2007.
...
3484
days inactive
3498
days old
2 comments
2 participants
participants (2)
-
Christine Choirat -
David Kane